keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.88k stars 1.23k forks source link

Default KBFS mountpoint no longer created on Gentoo. #16050

Open jaccarmac opened 5 years ago

jaccarmac commented 5 years ago

Using Keybase on Gentoo, noticed after an update that my KBFS folder in /var/run/user/1000/keybase no longer existed. Seems to be due to a change in the run_keybase script: https://github.com/keybase/client/commit/3d9214879ec4ba99f3dd6f136f150eb3edfbaaf8#diff-47650c75f7c44ae86a5b4806e122e18eL290. $mountdir creation was removed without a new version in the added lines of that patch. Problem's easy enough to fix by changing the mountdir or creating it and restarting the service, but it seems that the removal of that line may have been mistaken? Don't see anything about it in the commit message in any case.

heronhaye commented 5 years ago

Thanks for the report. kbfsfuse now attempts to create the mountdir automatically now if it doesn't exist, which is why that was removed from the script.

What's in your keybase config get -d -b mountdir and echo $XDG_RUNTIME_DIR?

Also, what is the result of

keybase version
kbfsfuse --version
jaccarmac commented 5 years ago

Ah, interesting.

I've updated my mountpoint to get things to work, but it was /var/run/user/1000/keybase/kbfs when I observed the issue.

$XDG_RUNTIME_DIR is /var/run/user/1000

Keybase is 3.0.0 but kbfsfuse reports 1.0.2. On the packaging side only the keybase ebuild got updated, so that version mismatch is likely the problem. Hadn't considered it since Keybase was still talking to KBFS when the directory existed.

Ebuild versions are 3.0.0 and 2.11.0 respectively. The KBFS one seems a bit outdated, as I updated Keybase from 2.13.1.

heronhaye commented 5 years ago

In January we moved KBFS into the client repository at https://github.com/keybase/client/tree/master/go/kbfs, so from glancing at https://gitweb.gentoo.org/repo/gentoo.git/diff/app-crypt/kbfs/kbfs-2.11.0.ebuild?id=7cb8d9c30a3e0746ee7f0be432b66fefada0d75d, it's possible that your build system is still using the old code at https://github.com/keybase/kbfs/. (We actually updated this repo to fail to build, but only recently).

Sorry, I messaged a few distros that were packaging Keybase to let them know of the repo move but didn't catch all of them.

jaccarmac commented 5 years ago

Roger that. I've emailed the Gentoo maintainer, seems like a packaging issue.

heronhaye commented 5 years ago

They can still be separate packages by the way - you can use keybase without kbfs if you want to package them as separate ebuilds. But if you use kbfs you need to upgrade both at the same time.

heronhaye commented 5 years ago

Okay, let me know if it works after KBFS is updated to the new remote. Thanks!