search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.85k stars 1.22k forks source link

Insistent notification when rekeying fails #2346

Open FiloSottile opened 8 years ago

FiloSottile commented 8 years ago

benjojo put something in our private folder before I installed KBFS. Then uninstalled KBFS. Now I get a "Rekeying" notification every 5 minutes (and no other clue that there are pending files in the UI)

Keybase GUI Version: 1.0.14-20160315130050+fc26e6b

strib commented 8 years ago

Oh hrm. Can you please do a keybase log send and let us know the resulting ID? Thanks.

FiloSottile commented 8 years ago

c532402cd2471054e00b681c

strib commented 8 years ago

@FiloSottile: can you provide a screenshot of what you mean by a "Rekeying" notification? There are two possibilities I can think of:

  1. A small toast style fade-in-fade-out notification that says "This device does not yet have read access to directory /keybase/private/benjojo,filippo, ask one of the other directory participants to log into Keybase to grant you access automatically". As far as I know this would only happen while you (or some part of your system) is accessing the folder directly.
  2. A more centered, GUI-style prompt asking you for your passphrase and/or a paper key to accomplish the rekey. This could happen once every 10 minutes (though we have an open issue for the near future where this should only happen once, and then on demand as you try to access the folder after that).

According to your logs, I think (1) should only have happened when you were trying to look at the folder explicitly, and that seems to have only occurred around 2016-03-15T17:08:27.

As @oconnor663 said on #2345, there are logs every 10 minutes showing the periodic rekeyWithPrompt call, which theoretically can result in (2). However from the looking at the code, it doesn't seem like it should prompt you when the TLF hasn't yet been keyed for you at all. Maybe there's a bug there though.

FiloSottile commented 8 years ago

It's a OS X Notification Center toast like in (1), but with a much shorter message.

image

Interestingly, they ceased a few hours ago.

strib commented 8 years ago

Ahhhh, got it. That makes sense. I was thinking it should have been the error notification, but it's just the informational one. In that case it must have been due to the every-10-minute job we have. For what it's worth, the fact that it's on the 10-minute mark is a coincidence -- it looks like that's just happens to be when your computer came back online after a snooze.

I can't explain why they stopped, but if you want to send a new log I can look into it.

strib commented 8 years ago

(Also, as mentioned above, we will be fixing that periodic process in the next major release.)