search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.88k stars 1.23k forks source link

Unable to delete KBFS folder recursively (in public) #4087

Open robinsmidsrod opened 8 years ago

robinsmidsrod commented 8 years ago

When I sit in K:\public\robinsmidsrod\ I'm unable to remove my folder "my_ssh_keys" which has another subfolder called "current". It seems like the KBFS service just hangs when this happens.

my log id: ddf5cb0610fb1e0c9158121c

strib commented 8 years ago

@taruti I don't see any RemoveDir calls for "current" in the libkbfs logs, and I'm not sure what to expect in the libdokan logs. Can you see if you can find where it hangs please?

robinsmidsrod commented 8 years ago

@strib For some reason the bug seems to be gone this morning when I tried again, but at this point I deleted ssh_keys/current folder before I deleted ssh_keys. Not sure if this could've been the trick. Not sure if avoiding the recursive delete fixed it or you did something server-side.

strib commented 8 years ago

Nothing changed on our end. @taruti: please look into recursive delete on dokan when you get a chance.

taruti commented 8 years ago

@robinsmidsrod To make sure - were you using explorer to try the recursive delete that didn't work?

At least in a test case a recursive delete with a somewhat complex filetree and delete in Explorer worked fine. Nothing stands out in the logs, will investigate this further and add some extra logging.

robinsmidsrod commented 8 years ago

@taruti From what I've managed to figure out, I tried to perform a recursive delete using explorer.exe. If I try that with a trivial folder structure it will fail, and at that point it seems like it's unable to delete an individual folder (no recursion) until the shell integration service is restarted (which usually means a reboot). What's important to remember is that none of the folders contain any files.

Not sure if that makes a difference or not.