search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.91k stars 1.23k forks source link

Search gives non-intuitive results for partial non-usernames #5411

Open james-antill opened 7 years ago

james-antill commented 7 years ago

Keybase GUI Version: 1.0.18-20161219185928+7868d49

The search (in both GUI and cmd line) gives weird results for partial searches.

This is probably easier with examples:

% keybase search james | egrep 'ill|jwt'
jwt twitter:elzzon
% keybase search jamesa | egrep 'ill|jwt'
illiterat twitter:jamesantill github:james-antill facebook:james.antill http:://www.and.org
% keybase id jwt
▶ INFO Identifying jwt
✔ public key fingerprint: 4B8D AA7B CA0F 3016 D5E9 942C B083 FB0E F609 051B
✔ "elzzon" on twitter: https://twitter.com/elzzon/status/695473558743605248 [cached 2017-01-16 13:31:37 EST]
strib commented 7 years ago

cc: @malgorithms

malgorithms commented 7 years ago

if I'm reading that correctly, is it the concern that the first query is missing some of the results picked up by the 2nd query?

It's because the search fn right now just gets the best N results, for some fuzzy definition of best. We may change this in the future, so I'll leave this open.

(If I'm misreading the issue, please add extra info.)

james-antill commented 7 years ago

Yeh, I'd say two related issues:

  1. best N drops some results with nothing in the UI showing that there are more results.
  2. The "fuzzy best" match is surprising, given jwt just matches on real name whereas illiterat matches on multiple fields, including real name and the shown fields.