Closed maxtaco closed 9 years ago
I think there are two compelling reasons to come up with a nice solution here: (1) as @chrisnojima says, to make it easy to push client fixes in the case of a calamity; and (2) to make it easier for people to contribute plugins to is (think: slack).
For instance, when working on the bitbucket scraper (from keybase/proofs#5), there are just a large number of things that need to change in both the proofs repo itself, and also in our keybase/keybase code tree. See keybase/keybase@d4ba923c4c1f79134cb0484697b9601af426876c for an example of all of the boilerplate.
I think the finished product here will be, for each bitbucket-like integration:
Why two files and not one? The first file will change infrequently and should be pinned to the KB merkle tree. The second is internal and need not be so restricted.
I'm on board for both of these things:
In terms of prioritization, I think 1 is more important, because we'll want to apply it to all our existing proofs.
Do you think it might make sense instead to fold 95% of the integrations into this framework, but still hand-code the important remaining 5% like instagram and FB?
I guess my point is that pretty much every integration we've had so far has had weird custom stuff about it. I know we can't swallow up all those generalizations, but I'm concerned how we can get to 95%. Or even 75%.
either way, these two things are separate issues, right? (1) the proof verification language, and (2) generalization of proofs across the board (hunting, etc.)?
they are, but i think we'd benefit from attacking them in tandem
The first question to resolve is should the scheme in (1) be a dumbed-down language, or should it be JS? I prefer the form if we can squeeze all of current proofs into it. Let's make a discovery ticket for that -- #962.
Keybase proof language will allow us to quickly change rules for client scraping, in case Twitter or Github et al make a breaking change. ... More details to come on this ticket ...