search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.83k stars 1.22k forks source link

Updater prompts again if interrupted (after app restarts the updater) #6040

Open bobinson opened 7 years ago

bobinson commented 7 years ago

I keep getting updates to new version and the changelog remains the same.

Though this bug is not an issue in itself, it undermines the trustworthiness of the application.

The latest is given below and will keep posting / updating the subsequent update notifications 2017-02-27_11-08-45 .

maxtaco commented 7 years ago

cc: @gabriel

bobinson commented 7 years ago

I got the above message twice today.. got second message 2 hours and 13 minutes after the first one. Got exactly similar screen shots. So no posting it here.

cjb commented 7 years ago

@bobinson Are you accepting or ignoring the updates? Please could you run keybase log send and tell us the ID?

bobinson commented 7 years ago

@cjb - accepted the updates. (both)

my log ID : 00972b0a3e5b357930d0e51c

cjb commented 7 years ago

Thanks, that's odd. CC @gabriel

gabriel commented 7 years ago

The updater showed prompt and then it started downloading. While downloading the app was quit. When the app was quit it stopped the updater. So when app was restarted, it did an update check and prompted again. It successfully updated that 2nd time though.

So if the updater is interrupted or failed, it will prompt again for the same update, which I suppose is confusing.

There are probably a few ways to deal with this. We could remember if a user already accepted an update and not prompt in that case?

gabriel commented 7 years ago

Tracking this internally at https://keybase.atlassian.net/browse/DESKTOP-2999

ryedin commented 6 years ago

Any updates on this issue? I got the update message several times yesterday (despite accepting twice), and again today. Am going to decline it this time. Agreed with earlier comment that it undermines the trustworthiness of the application.

JKirchartz commented 6 years ago

I'm having the same issue with updater not respecting the "autoupdate" checkbox, and prompting multiple times for updates

Log ID: 98d32d002006082be84ec01c

Keybase GUI Version: 1.0.45-20180305115557+3a1c65a