search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.91k stars 1.23k forks source link

RPC-API: Key gen tweaks #73

Closed gabriel closed 9 years ago

gabriel commented 9 years ago

keyGenSimple calls mykeyUi.getPushPreferences and secretUi.getNewPassphrase.

For the UI client, these can be method params?

 keyGenSimple(array<PGPIdentity> ids, PushPreferences pushPrefs)

I assume by default the key is triplesec'ed with the keybase password in the keyring and I don't have to specify. Or maybe you don't cache the password, in which case:

keyGenSimple(array<PGPIdentity> ids, PushPreferences pushPrefs, string password)

you could rename to keyGenDefault since its more of a default thing than a simple thing ;)

gabriel commented 9 years ago

Also I'm probably sending null for ids. Do you add the default keybase user?

Also at the very end, if I send public and private = NO, it gives a 901, key not found error. Also should keyGen return a key id? But I'm always setting at least public = YES, so this isn't a big deal.