search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.88k stars 1.23k forks source link

Set the EWMH property _NET_WM_ICON #9065

Open colonelpanic8 opened 6 years ago

colonelpanic8 commented 6 years ago

The linux keybase client does not seem to set the EWMH property _NET_WM_ICON, which is how many applications display information about open windows:

https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm140200472568384

It would be great if keybase started setting it, so that the keybase application window could more easily be identified.

colonelpanic8 commented 6 years ago

I believe that all that needs to be done is something like this:

https://github.com/owcz/simplenote-electron/blob/e0e815bc70a3424aaade9c921509c53f0c7a071c/desktop/app.js#L48

here: https://github.com/keybase/client/blob/194ff184d2725251ada4d59319abba9c3c41b4e1/shared/desktop/app/main-window.js#L30

I'm not super familiar with electron, or where exactly you assets are positioned, or I would make the change myself.