search

keybase / client

Keybase Go Library, Client, Service, OS X, iOS, Android, Electron
BSD 3-Clause "New" or "Revised" License
8.82k stars 1.22k forks source link

Impossible to create a new PGP key if a user doesn’t have GPG installed on the local computer. #9638

Open Elvira-Melentyeva opened 6 years ago

Elvira-Melentyeva commented 6 years ago

Impossible to create a new PGP key if a user doesn’t have GPG installed on the local computer.

How to reproduce

  1. Create a user
  2. Select ‘Add a PGP key’
  3. Select ‘Get a new PGP key’
  4. Fill your name and emails
  5. Press the button for key creation

Expected result

A user should get a message that they need to install GPG. Or it should just work without it somehow.

Actual result

Nothing is happening: no error message and no key created.

After installing GPG with brew install gpg and restarting Keybase I can generate the key successfully.

Enviroment

macOS 10.13.1 Keybase GUI Version: 1.0.34-20171027003854+8e989533a

maxtaco commented 6 years ago

This would be a surprise, are you sure? How did you observe that no key was created?

Elvira-Melentyeva commented 6 years ago

The UI didn't indicate anything happening. When I restarted the app, the PGP key was not shown on the profile.

maxtaco commented 6 years ago

Ok, thanks. That sounds like a UI bug. We'll take a look.

zanderz commented 6 years ago

likely related to https://github.com/keybase/client/issues/10448. Tracking internally with DESKTOP-6076

zanderz commented 6 years ago

This was fixed with https://github.com/keybase/client/pull/10550, which will be included in an upcoming release