search

keybase / go-crypto

[mirror] Go supplementary cryptography libraries
https://godoc.org/golang.org/x/crypto
BSD 3-Clause "New" or "Revised" License
50 stars 20 forks source link

Bring in the latest from golang/crypto upstream #42

Open brianmario opened 7 years ago

brianmario commented 7 years ago

:wave: hello again!

I'm not sure if this is the way you normally do this, or if commits are cherry-picked more intentionally. So I thought I'd propose this and start the discussion on the best way to move forward.

We'd like to continue using the keybase fork of the golang/crypto repo for the other additions that have been added, but I also wanted to get things synced up so further work could be added based on top of it - specifically now that a ed25519 implementation exists upstream. I'd like to try and get support for that added to the openpgp package.

What do you think would be the best way forward?

FYI there were a handful of merge conflicts but I unfortunately didn't keep track of which files they were :\

maxtaco commented 7 years ago

good idea, we should do this, we're just swamped right now with other stuff. will hopefully get to it soon.

zapu commented 7 years ago

I can have a try with this once https://github.com/keybase/go-crypto/pull/40 is done