Fix rsa large exponent keys

keybase / go-crypto

[mirror] Go supplementary cryptography libraries

https://godoc.org/golang.org/x/crypto

BSD 3-Clause "New" or "Revised" License

50 stars 20 forks source link

Fix rsa large exponent keys #76

Closed zapu closed 5 years ago

zapu commented 5 years ago

Add crypto/rsa fork back in to fix large exponent keys.

maxtaco commented 5 years ago

Any chance of upstreaming our patch?

zapu commented 5 years ago

They rejected it last time: https://github.com/golang/go/issues/17970 might be worth it to try again.

maxtaco commented 5 years ago

Ah, urg, ok. What about the other approach, which is to shitcan this key. Does that break this guy's account?

zapu commented 5 years ago

It does, unfortunately. But we had this for years until I accidentally switched to importing crypto/rsa instead, so we are essentially just fixing the regression here. I think there may be more people in similar situation who hasn't reported it.

maxtaco commented 5 years ago

OK 👍