search

keybase / go-crypto

[mirror] Go supplementary cryptography libraries
https://godoc.org/golang.org/x/crypto
BSD 3-Clause "New" or "Revised" License
50 stars 20 forks source link

fix panic on parsing elgamal sign-or-encrypt private key #81

Closed heronhaye closed 5 years ago

heronhaye commented 5 years ago

Ref: https://github.com/keybase/client/issues/18944

maxtaco commented 5 years ago

Also, it seems like we can fix CI if we don't test the failing subdir (or merge changes from that subdir in, grr...)

heronhaye commented 5 years ago

Did this ssh package use to pass CI?

maxtaco commented 5 years ago

I'm guessing that it broke with 1.12

On Fri, Aug 23, 2019 at 3:09 PM heronhaye notifications@github.com wrote:

Did this ssh package use to pass CI?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/keybase/go-crypto/pull/81?email_source=notifications&email_token=AAGTT73R23OYWOBAED4IBUTQGAYYDA5CNFSM4IPCMKF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BCSZI#issuecomment-524429669, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGTT7ZMOVAOY4UN7SNXGIDQGAYYDANCNFSM4IPCMKFQ .

heronhaye commented 5 years ago

Ok should I try to rebase that directory? I saw there were only 2 commits from us in ssh

maxtaco commented 5 years ago

That would be super

maxtaco commented 5 years ago

We actually use it for terminal sensing: minterm/minterm_nix.go: "github.com/keybase/go-crypto/ssh/terminal"

heronhaye commented 5 years ago

It was becoming a pain to merge in changes to the ssh package, they added this new dep on internal/chacha20 which had to be vendored since its internal, and so on. Since we aren't using this ssh package anywhere except for ssh/terminal, is it ok to get rid of all those files?