search

keybase / go-crypto

[mirror] Go supplementary cryptography libraries
https://godoc.org/golang.org/x/crypto
BSD 3-Clause "New" or "Revised" License
50 stars 20 forks source link

fix panic on parsing EmbeddedSignature signature, #82

Closed izouxv closed 4 years ago

izouxv commented 4 years ago

add SignRevocationKey

zapu commented 4 years ago

Thank you for your contribution.

I'm assuming this code allows creation of key revocation signatures for new or existing key bundles, and then such bundle can be serialized with said revocation.

In order to merge, we are going to need test(s) (probably in signature_test.go file) that: 1) shows example use of new API, 2) confirms that it works, by showing that go-crypto can deserialize key created with SignRevocationKey back and understand the serialized revocation.

izouxv commented 4 years ago

fix panic on parsing EmbeddedSignature signature, and remove outSubpacket lenght large then zero condition in CrossSignKey. FlagSign enable and key bits large then 2048, the error will appear