search

keybase / go-keybase-chat-bot

Official Go Keybase chat bot SDK
BSD 3-Clause "New" or "Revised" License
111 stars 38 forks source link

make team a reference (optional) in kvstore client. fix example. #49

Closed mmou closed 4 years ago

joshblum commented 4 years ago

cc @songgao jirabot uses this right?

songgao commented 4 years ago

I don't think this affects the jirabot since it uses the js lib (and I have a ticket to make that one optional too).

I wonder if it's worthwhile to have a type for teamname here, so that we don't have to do the string pointer dance. The type can be either a struct, or just defined as type TeamName *string but with methods for accessing it and accessing whether it's empty. Then we can have something like AutoTeamName defined in package for user to use.