search

keybase / go-keychain

Golang keychain package for iOS and macOS
MIT License
573 stars 120 forks source link

Remove deprecated function call #99

Closed danielchatfield closed 1 year ago

danielchatfield commented 1 year ago

As suggested in https://github.com/keybase/go-keychain/issues/88 PR https://github.com/keybase/go-keychain/pull/77 inadvertently re-introduced a deprecated call. This PR removes that call but preserves all the other functionality that was intentionally re-introduced.

# github.com/keybase/go-keychain
cgo-gcc-prolog:53:11: warning: 'SecKeychainItemDelete' is deprecated: first deprecated in macOS 10.10 - SecKeychain is deprecated [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychainItem.h:257:10: note: 'SecKeychainItemDelete' has been explicitly marked deprecated here
danielchatfield commented 1 year ago

@joshblum This should hopefully fix the deprecation warnings that plague the logs of any project that depends on this library.

joshblum commented 1 year ago

Thanks @danielchatfield