search

keybase / kbfs

Keybase Filesystem (KBFS)
https://keybase.io/docs/kbfs
BSD 3-Clause "New" or "Revised" License
1.21k stars 137 forks source link

keybase-redirector doesn't die/reload after run_keybase #1510

Open PresGas opened 6 years ago

PresGas commented 6 years ago

On Debian/Ubuntu Linux, subsequent runnings of run_keybase results in more than one keybase-redirector.

Either the restart does not kill the child process or it just doesn't get cleaned up. No noticable performance issues, but could be problematic. Could it be because it is run as root and run_keybase is as a normal user?

rmday@cacodaemon:~$ ps -aux |grep keybase-redirector root 7870 0.0 0.0 759336 4592 ? Sl 09:33 0:00 keybase-redirector /keybase root 8155 0.0 0.0 685348 4260 ? Sl 09:33 0:00 keybase-redirector /keybase root 8383 0.0 0.0 609952 4304 ? Sl 09:34 0:00 keybase-redirector /keybase rmday 8819 0.0 0.0 14352 1068 pts/4 R+ 09:38 0:00 grep --color=auto keybase-redirector

Attaching log shortly.

PresGas commented 6 years ago

Success! Your log ID is:

7241292499e970e279ca531c

strib commented 6 years ago

Thanks, I'll look into it tomorrow. run_keybase is not supposed to kill one that's already running, but the new one it tries to start is supposed to stop on its own, leaving the original one running.

PresGas commented 6 years ago

Anything else you need from me or testing subsequent releases, let me know.

strib commented 6 years ago

No I'm good, just busy. lots of issues came in this weekend. This one is still in my queue, will get to it as soon as I can.

strib commented 6 years ago

Should be fixed with #1511. Thanks for the report!