keybase_service_base: don't try to use a nil ID on identify error

keybase / kbfs

Keybase Filesystem (KBFS)

https://keybase.io/docs/kbfs

BSD 3-Clause "New" or "Revised" License

1.21k stars 137 forks source link

keybase_service_base: don't try to use a nil ID on identify error #1977

Closed strib closed 5 years ago

strib commented 5 years ago

Worth adding a test that would have failed on the bug that was causing the keybase.pub problem?

Can't really test this file in this repo because it depends heavily on interacting with a real service. So the test would need to be in kbfsdocker. It would be nice to have such a test, but it would take some effort and I'm not sure about the priority of it.

jzila commented 5 years ago

Yeah I'm inclined to agree with Strib--KBFSDocker isn't ideal for regression tests because each tests has such high overhead.