keybase / keybase-issues

A single repo for managing publicly recognized issues with the keybase client, installer, and website.
902 stars 37 forks source link

Should be able to use the avatar of services like Facebook and Github, instead of just browsing using Filepicker.io #107

Closed phindmarsh closed 10 years ago

phindmarsh commented 10 years ago

When getting an avatar I thought it'd let me just pick my Facebook or Github profile picture, rather than trawling through my albums or repositories. Would be a good shortcut, since the one in the Facebook album needs cropping which isn't supported.

seanherron commented 10 years ago

Why not just use gravatar?

phindmarsh commented 10 years ago

Yeah, good point, that works too.

malgorithms commented 10 years ago

Yes, love this idea. We also need to drop filepicker.io before going beta anyway, because a 3rd party JS include is not acceptable.

Gravatar is less appealing than the other identity choices (pulling from your connected identities) because of email exposure concerns, but we might add it as an option that can be turned on.

djc commented 10 years ago

You could pull in the gravatar image? You already have my email, you could test to see if there's a gravatar account and download that image for use (or ask me about it), right? Seems like the email exposure would happen only if you hotlink to gravatar. (FWIW, I ended up pulling my own picture off gravatar to re-upload it.)

jasonkarns commented 10 years ago

And at the very least, just let me paste in an image URL.

tildelowengrimm commented 10 years ago

You already have email exposure because most GPG keys come with email addresses already attached.

malgorithms commented 10 years ago

@flamsmark yeah, true on that, although it's unclear to me if someone joining under email address X, which might not be what's in their key, would want us to pull their gravatar from their key or their joining address. Which means users will demand more settings, and some won't find the settings, and some will be confused.

I'm increasingly convinced images on keybase should just be your identities which you've connected, and key-email<->gravatar can be one of them.

Consider the presentation that instead of a single image you select, each of your identities gets your thumbnail for that service right next to it.

This causes 2 questions:

phindmarsh commented 10 years ago

One caveat I can see for that scenario is when multiple identities share the same image (like mine do), which would mean a collage would just be a tile of the same image. Perhaps just pick one as the 'default' or 'use this for my avatar' type thing?

malgorithms commented 10 years ago

good point.

hmm, I'm starting to imagine the following UI:

you still have the circle section on the left of your profile. when you click that it lets you upload one directly or pick one from your identities. if you have multiple gravatars (your email addresses we know about), we'll put them in the list too.

So your default thumbnail, as @phindmarsh says, is one you can pick (and it'll be obvious how), but we will still pull in identity images from proofs and display them next to your identities.

thoughts?

phindmarsh commented 10 years ago

Seems reasonable to me, gets the best of both without too much complication.

tildelowengrimm commented 10 years ago

I like the idea of displaying an image which is already linked to your identity. In fact, I especially like the idea of not supporting images which aren't linked.

If users can upload images independently, that's just another unauthenticated thing for which Keybase has to be an authority. The more things that Keybase has to be the authority for, the more problems there'll be later, especially for federation (issue #162).

To me, this suggests the following possible image sources:

malgorithms commented 10 years ago

Filepicker is stripped! Woo-hoo.

Now your images are pulled automatically from every identity proof you've made. You can select from among them to choose your profile pic.

The site is rebuilding people's pics now.

I don't think we'll put the effort into implementing gravatar by itself, because anyone who's a fan of gravatar will likely use that same image on one of their connections (such as github). And as @flamsmark said it's simpler if the photos just come from your proven connection.

Anyway, so happy to have filepicker removed. We can't have any Githubissues.

  • Githubissues is a development platform for aggregating issues.