search

keybase / keybase-issues

A single repo for managing publicly recognized issues with the keybase client, installer, and website.
899 stars 37 forks source link

Folders should only be created when pressing enter (not dynamically while typing) #2455

Open crahan opened 8 years ago

crahan commented 8 years ago

On OS X (using zsh), when navigating to a new folder (e.g. cd /keybase/public/filipedoe), keybase will create all intermediate folders too (for any existing users). This clutters the filesystem with a lot of unwanted folders for users I have no intention to colaborate with. In this example you end up with the following folders under /keybase/public/:

The same happens with private shared folders (e.g. /keybase/private/myuser,filipedoe).

Folders should only be created when pressing enter after executing cd /keybase/public/filipedoe, not dynamically as you're typing the command.

strib commented 8 years ago

Are you using a zsh plugin that does auto-auto-complete? (Or maybe zsh does that by default, I'm not sure.) Unfortunately we can't tell if it's the user doing a lookup by hitting enter or the shell doing it on the user's behalf. Anyhow, I believe we have a PR out that will fix this (keybase/kbfs#95), but we're still working on some corner cases.

crahan commented 8 years ago

I am using a zsh plugin that does autocomplete, but the issue persists with the plugin disabled. Thanks for the link to the PR!

strib commented 8 years ago

If you have some kind of dynamic shell coloring enabled, that will also likely result in the same lookup call to the file system, to figure out what kind of file the incompletely-typed name represents.

crahan commented 8 years ago

I'll follow the fix you linked to earlier. For now I'll switch back to bash as temporary solution.