search

keybase / keybase-issues

A single repo for managing publicly recognized issues with the keybase client, installer, and website.
902 stars 37 forks source link

Updating public key from website is broken #4060

Open diafygi opened 2 years ago

diafygi commented 2 years ago

Steps to reproduce

  1. Login on the website and load your profile (e.g. https://keybase.io/diafygi)
  2. Next to your public key, click the "edit" link.
  3. Two options will appear: "Update my key (I edited it elsewhere)" and "Host an encrypted copy of my private key".
  4. Clicking "Update my key..." doesn't do anything. A console error says, Uncaught TypeError: window.SigModalUis[link_data.sig_gen] is not a constructor

Fix

It appears this link doesn't have the appropriate data attribute that triggers the public key update flow.

To manually fix, if you inspect the link element and manually add the data field, the link works again:

Original:

<a href="#_" class="link-add-signed-statement">Update my key (I edited it elsewhere)</a>

Change to:

<a href="#_" class="link-add-signed-statement" data-ss_sig_gen="PGPUpdate">Update my key (I edited it elsewhere)</a>
aspensmonster commented 2 years ago

I also ran into this issue. I can also confirm that the manual fix by @diafygi works. I was able to update my public key (I bump the expiration dates on my keys every other year) and now https://keybase.io/aspensmonster has the updated public key with the updated expirations.