search

keybase / node-forge-sigchain

A node library to sync and process user sigchains
BSD 3-Clause "New" or "Revised" License
7 stars 10 forks source link

Expand pgp_update generation, more options for key gen #2

Closed zapu closed 7 years ago

zapu commented 7 years ago

Mostly pgp_update improvements. It can change expiration times and change identities now. This was used to test signature chain verification for expiration bugs where expiring pgp key was invalidating the whole chain.

Changes to _compute_time: it is used for more things now (like key.generated for key generation time, which might be different than link creation time), but _compute_time will only advance simulation clock when handling linkdesc.ctime, and it will always happen at the very beginning of forging link (used to be in _populate_proof so at the very end).

4.cson has an example of pgp_update that moves key expiration and changes identity name.

maxtaco commented 7 years ago

Small comment, otherwise looks good

maxtaco commented 7 years ago

👍