keybase / node-installer

An installer/updater for the node client.
BSD 3-Clause "New" or "Revised" License
117 stars 9 forks source link

Space in username on Windows causes error #51

Open dbellizzi opened 10 years ago

dbellizzi commented 10 years ago

My username has a space in it, and that is causing keybase-installer to fail.

C:\Windows\system32>keybase-installer -d
debug: + cmd.run 0.1.16
debug: ++ Installer::run
debug: +++ Installer::test_gpg
debug: --- Installer::test_gpg -> OK
debug: +++ Installer::test_npm
debug: --- Installer::test_npm -> OK
debug: +++ Installer::test_npm_install
debug: ||| Writing temporary file, to see if install will work: C:\Program Files
 (x86)\nodejs\.keybase_test_install_0aaf8216bd44f4ba02aa
debug: ||| Unlinking file: C:\Program Files (x86)\nodejs\.keybase_test_install_0
aaf8216bd44f4ba02aa
debug: --- Installer::test_npm_install
info: Made temporary directory: C:\Users\DOMINI~1\AppData\Local\Temp\keybase_ins
tall_ckJ_glwqHvLTWS4V_jYXFQ
debug: +++ Make new permanent keychain
debug: ||| mkdir_p parent C:\Users\Dominick Bellizzi\.keybase-installer
debug: --- Made new permanent keychain
debug: +++ Make/check empty pubring C:\Users\Dominick Bellizzi\.keybase-installe
r\keyring\pubring.gpg
debug: ||| Found one
debug: --- Made/check empty pubring -> true
debug: +++ Make/check empty secring C:\Users\Dominick Bellizzi\.keybase-installe
r\keyring\secring.gpg
debug: ||| Found one
debug: --- Made/check empty secring -> true
debug: +++ Make/check empty trustdb C:\Users\Dominick Bellizzi\.keybase-installe
r\keyring\trustdb.gpg
debug: ||| Found one
debug: --- Made/check empty trustdb -> true
debug: || Call to gpg: { args: [ '-k', '--with-fingerprint', '--with-colons' ],
debug:   quiet: true }
debug: || Mutate GPG args; new args: --no-default-keyring --keyring C:\Users\Dom
inick Bellizzi\.keybase-installer\keyring\pubring.gpg --secret-keyring C:\Users\
Dominick Bellizzi\.keybase-installer\keyring\secring.gpg --trustdb-name C:\Users
\Dominick Bellizzi\.keybase-installer\keyring\trustdb.gpg -k --with-fingerprint
--with-colons
debug: +++ cleanup C:\Users\DOMINI~1\AppData\Local\Temp\keybase_install_ckJ_glwq
HvLTWS4V_jYXFQ
info: cleaning up tmpdir C:\Users\DOMINI~1\AppData\Local\Temp\keybase_install_ck
J_glwqHvLTWS4V_jYXFQ
debug: --- cleanup C:\Users\DOMINI~1\AppData\Local\Temp\keybase_install_ckJ_glwq
HvLTWS4V_jYXFQ -> OK
error: exit code 2
warn: usage: gpg [options] [filename]

It is fine if I run it with:

keybase-installer  -k "C:\Users\DOMINI~1\.keybase-installer\keyring"

This is Windows 7 x64, and I'm running as an administrator, but I don't think it matters.

janus-rose commented 10 years ago

I had the same problem in https://github.com/keybase/node-installer/issues/48 - My username also has a space, but I printed as "USER" in the paste.

Running the installer as noted above worked.