Better handle whitespace in frame

keybase / saltpack

a modern crypto messaging format

https://saltpack.org/

BSD 3-Clause "New" or "Revised" License

992 stars 63 forks source link

Better handle whitespace in frame #11

Closed mpcsh closed 8 years ago

mpcsh commented 8 years ago

frame.go now handles arbitrary amounts and combinations of whitespace in between words in either the header or the footer. It doesn't work with whitespace in the middle of a word (e.g. 'KEY BASE'), so the spec has been updated as we decided we don't want it to do that.

coveralls commented 8 years ago

Coverage increased (+0.03%) to 85.327% when pulling d7a5cc64cee3192bfed4fa30771e932208c786ef on mark/CORE-3385 into bde25349b648d471c05bfc77062eba282e887e98 on master.

mpcsh commented 8 years ago

Alright, ready for review!

coveralls commented 8 years ago

Coverage increased (+0.4%) to 85.659% when pulling cfcb06c4aea33e7d7c9db54c3dc546d2bc939b78 on mark/CORE-3385 into bde25349b648d471c05bfc77062eba282e887e98 on master.

mpcsh commented 8 years ago

I have no idea what the travis bug down there is

oconnor663 commented 8 years ago

Sounds real:

--- FAIL: TestNewlineInFrame (0.01s)
    armor62_encrypt_test.go:86: Error in framing: wrong number of words (6)

mpcsh commented 8 years ago

Oof, didn't notice that. Will fix.

mpcsh commented 8 years ago

Fixed in ca6b1d0

coveralls commented 8 years ago

Coverage increased (+0.03%) to 85.327% when pulling ca6b1d051d1207d40cba07530ef6f019224d44ec on mark/CORE-3385 into bde25349b648d471c05bfc77062eba282e887e98 on master.

coveralls commented 8 years ago

Coverage increased (+0.03%) to 85.327% when pulling 01c04ddbc219affec1bd293385aaafa652a0b932 on mark/CORE-3385 into bde25349b648d471c05bfc77062eba282e887e98 on master.

coveralls commented 8 years ago

Coverage increased (+0.03%) to 85.327% when pulling 08418271b012391946f203e59ed4e43a912d4a2f on mark/CORE-3385 into bde25349b648d471c05bfc77062eba282e887e98 on master.

coveralls commented 8 years ago

Coverage increased (+0.04%) to 85.335% when pulling f96c8ae9bf54e4356ab5f0bdcf34cc24e5ab9365 on mark/CORE-3385 into bde25349b648d471c05bfc77062eba282e887e98 on master.

oconnor663 commented 8 years ago

:ship: with comments above. I can show you how to push it to saltpack.org.