Plumb through versions in signing/verifying

keybase / saltpack

a modern crypto messaging format

https://saltpack.org/

BSD 3-Clause "New" or "Revised" License

992 stars 63 forks source link

Plumb through versions in signing/verifying #34

Closed akalin-keybase closed 7 years ago

akalin-keybase commented 7 years ago

This is needed to be able to switch to isFinal flag for signing V2.

coveralls commented 7 years ago

Coverage increased (+0.006%) to 86.234% when pulling e2f3d7927c470c2386cdaf26a6a78f142c59c47b on akalin/sign-v2 into a1ffd450aa36f3351777ac1718c963fb226968fe on master.

akalin-keybase commented 7 years ago

Aside from the places I commented, this PR is just plumbing through the version/versionValidator arg.

coveralls commented 7 years ago

Coverage remained the same at 86.228% when pulling 5403b3ba4d008761cd1646329cc3adc42bf46b0b on akalin/sign-v2 into a1ffd450aa36f3351777ac1718c963fb226968fe on master.

coveralls commented 7 years ago

Coverage remained the same at 85.285% when pulling 8443e6d9d6df27bc2ab666666a515c178d733112 on akalin/sign-v2 into 6bbb568045ea5adf3db25f5e853c910c4293d135 on master.

coveralls commented 7 years ago

Coverage remained the same at 85.285% when pulling 625c62b4b51fcaef5b9aee319194432e6b89b94c on akalin/sign-v2 into 6bbb568045ea5adf3db25f5e853c910c4293d135 on master.