search

keybase / saltpack

a modern crypto messaging format
https://saltpack.org/
BSD 3-Clause "New" or "Revised" License
989 stars 62 forks source link

Clarify ambiguity in encryption spec/example #87

Closed tomstoneham closed 3 years ago

tomstoneham commented 3 years ago

From #43, as well as packets.go, the final flag should be the first item in each payload packet in an encrypted message. However, the example currently places the final flag last in the payload packet, introducing ambiguity for those implementing the protocol. This commit changes the example to conform to the actual implementation behaviour.

tomstoneham commented 3 years ago

Not sure why CI is failing, this commit only changes files in spec/. Might need to take a look at .travis.yml.

oconnor663 commented 3 years ago

Thanks for the correction! It took me a while to page all this back in, but I think the original confusion might've been that the final flag is the last field (of 2) in the signcryption mode, but the first field (of 3) here in the encryption-only mode.

oconnor663 commented 3 years ago

@malgorithms can you do a pull for this fix on the webserver?

tomstoneham commented 3 years ago

Thanks for the quick merge @oconnor663! Have a good one.