search

keybase / saltpack

a modern crypto messaging format
https://saltpack.org/
BSD 3-Clause "New" or "Revised" License
989 stars 62 forks source link

Minor spec fixes #88

Closed tomstoneham closed 3 years ago

tomstoneham commented 3 years ago

This PR just corrects a couple of tiny issues I had with the saltpack spec.

First, it changes uses of "MB" to be "MiB", and adds the definition of 1 MiB (= 2^20 bytes) the first time it is referred to in each page of the spec. This is a really tiny pedantic thing, but I had to double check with the Go implementation when implementing the spec from scratch myself, since people often mean 10^6 bytes when they say MB. No worries if you don't want to merge this one :smile:

Second, it updates specs/saltpack.md to be in line with the current working links to the parts of the spec, and fixes a very small formatting bug in specs/saltpack_encryption_v2.md, which makes it appear weirdly when the Markdown is parsed.

Thanks!

oconnor663 commented 3 years ago

LGTM. Thanks again!

oconnor663 commented 3 years ago

We've pushed saltpack.org, so you should see these changes live now.

tomstoneham commented 3 years ago

Perfect, thank you!