search

keybase / triplesec

Triple Security for the browser and Node.js
https://keybase.io/triplesec
MIT License
399 stars 48 forks source link

too many comments? #70

Open alchmy opened 5 years ago

alchmy commented 5 years ago

I love what you are doing here, and am trying to grok the source so that I know how to use parts of the library for a project of my own. I am wondering about the code style, is it really necessary to include all the extra comments and versioning information ? Isn't the purpose of git to handle versioning?

https://github.com/keybase/triplesec/blob/master/src/enc.iced

AndersTornkvist commented 2 years ago

There are comments in the code so that others can understand the code easier.

As for the versions, there are actually (currently) four different versions of the TripleSec format. The current implementation needs to be able to decrypt messages from previous versions.