search

keyboardio / Chrysalis-Firmware-Bundle

Firmware sketches for boards supported by Chrysalis
GNU General Public License v2.0
31 stars 25 forks source link

Update sketches for `KeyEvent` changes #12

Closed gedankenexperimenter closed 3 years ago

gedankenexperimenter commented 3 years ago

This updates a bunch of firmware sketches to use the new macroAction() function.

In addition, the Model01 sketch was too big to fit in PROGMEM, so I removed some LED plugins, and changed the makefile so that it would be compiled with NDEPRECATED defined to save even more space.

gedankenexperimenter commented 3 years ago

I should say that I have not had time to test these changes (and in many cases, I lack the hardware to do so).

obra commented 3 years ago

Before this merges, I'd like to see if we can get the LED effects back, since that'd be a regression.

obra commented 3 years ago

It looks like OneShot is particularly heavy

00000736 T kaleidoscope::plugin::OneShot::onKeyEvent(kaleidoscope::KeyEvent&) /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-OneShot/src/kaleidoscope/plugin/OneShot.cpp:179 00000678 T __vector11 /Users/jesse/Documents/GitHub/Kaleidoscope/.arduino/data/packages/arduino/hardware/avr/1.8.3/cores/arduino/USBCore.cpp:547 00000428 T kaleidoscope::plugin::ActiveModColorEffect::onKeyEvent(kaleidoscope::KeyEvent&) /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-LED-ActiveModColor/src/kaleidoscope/plugin/LED-ActiveModColor.cpp:35 00000424 T kaleidoscope::Runtime::handleKeyEvent(kaleidoscope::KeyEvent) /Users/jesse/Documents/GitHub/Kaleidoscope/src/kaleidoscope/Runtime.cpp:150 00000408 T kaleidoscope::plugin::Qukeys::processQueue() /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-Qukeys/src/kaleidoscope/plugin/Qukeys.cpp:117 00000384 T keymapslinear 00000360 T kaleidoscope::plugin::MouseKeys::afterEachCycle() /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-MouseKeys/src/kaleidoscope/plugin/MouseKeys.cpp:96 00000356 T kaleidoscope::plugin::Macros::play(unsigned char const) 00000336 T kaleidoscope::plugin::EEPROMKeymap::onFocusEvent(char const) /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-EEPROM-Keymap/src/kaleidoscope/plugin/EEPROM-Keymap.cpp:95 00000332 T USB_Send(unsigned char, void const*, int) /Users/jesse/Documents/GitHub/Kaleidoscope/.arduino/data/packages/arduino/hardware/avr/1.8.3/cores/arduino/USBCore.cpp:258 00000298 T __vector_36 /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-Hardware-Keyboardio-Model01/src/kaleidoscope/device/keyboardio/twi.c:400 00000284 T kaleidoscope::plugin::OneShot::afterEachCycle() /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-OneShot/src/kaleidoscope/plugin/OneShot.cpp:330 00000284 T kaleidoscope::plugin::Qukeys::isQukey(kaleidoscope::MatrixAddr<(unsigned char)4, (unsigned char)16>) /Users/jesse/Documents/GitHub/Kaleidoscope/plugins/Kaleidoscope-Qukeys/src/kaleidoscope/plugin/Qukeys.cpp:302

gedankenexperimenter commented 3 years ago

I'm pretty surprised that OneShot is bigger than Qukeys, actually.

obra commented 3 years ago

Ended up killing Chase and NumPad to get things to fit.

obra commented 3 years ago

Merged manually. Thanks! (closing)