search

keyboardio / Chrysalis-Firmware-Bundle

Firmware sketches for boards supported by Chrysalis
GNU General Public License v2.0
32 stars 25 forks source link

Model01 experimental firmware has NumPad LED effect active #4

Open fluffy-critter opened 5 years ago

fluffy-critter commented 5 years ago

When switching to layer 1 while using the experimental firmware, the NumPad LED effect still activates, overriding whatever color scheme is configured in Chrysalis.

algernon commented 5 years ago

This will be a tough one. In theory, all we need is a way to disable the Numpad plugin. In practice, we need to figure out when to do that.

fluffy-critter commented 5 years ago

If you’re using chrysalis to edit your color maps do you ever want NumPad enabled? Or another possibility is to put a flag in the EPROM for which layer to use with NumPad and make it possible for it to be whatever you want.

algernon commented 5 years ago

If colormap is used, then numpad should be off, indeed. It's... not easy to do that without introducing a dependency on Numpad to Colormap, which I'd rather avoid. Unless - as you wrote - we write a byte to eeprom and use that to toggle Numpad off.

Alternatively, I could remove the Numpad plugin from the experimental firmware, under the assumption that people using the experimental firmware will want to use Colormap anyway.

(We should probably figure out what the goal of the experimental firmware are, and how much it can deviate from the default, but that's another topic...)

fluffy-critter commented 5 years ago

Alternatively, I could remove the Numpad plugin from the experimental firmware, under the assumption that people using the experimental firmware will want to use Colormap anyway.

That’s actually what I was getting at, sorry I wasn’t clear. :)

algernon commented 2 years ago

I will not be touching the Model01 firmware, but for the Model 100 firmware, we're in the process of phasing out the NumPad plugin in favour of Colormap + a suitable default palette & map.