search

keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
496 stars 64 forks source link

Fix ui theme preference 'system' for Linux #1161

Closed EvyBongers closed 8 months ago

EvyBongers commented 2 years ago

Is your feature request related to a problem? Please describe. Dark mode preference system doesn't follow my system preference (Linux).

Describe the solution you'd like On Linux, follow org.freedesktop.appearance.color-scheme when dark mode preference is set to system.

Describe alternatives you've considered Wait for Chromium/Electron to implement support. :)

Additional context Mostly created this ticket to start a discussion. This issue is true for any electron based app as well as chromium/chrome.

algernon commented 2 years ago

This is a tough one, because under at least GNOME, Chrysalis does follow the system preference. I guess Chromium/Electron implements that, which isn't surprising, considering Chromium is compiled against GTK3.

I tried to have a quick look if there are existing node packages that'd help us check the color-scheme, but didn't find any so far. I don't want to implement that directly in Chrysalis, but would be happy to use a module. Even if that module is built for Chrysalis' use primarily (we do the same with teensy-loader.js afterall).

EvyBongers commented 2 years ago

My guess would be that Gnome (also) updates the gtk setting for it, which Chrysalis does follow.

obra commented 8 months ago

Chrysalis now runs in-browser using WebSerial and WebUSB, so I'm closing out this issue as obsolete.