main/ipc_firmware: Only pull pre-releases when running -snapshot

keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards

https://github.com/keyboardio/Chrysalis#chrysalis

GNU General Public License v3.0

496 stars 64 forks source link

main/ipc_firmware: Only pull pre-releases when running -snapshot #1167

Closed algernon closed 2 years ago

algernon commented 2 years ago

To match user expectation (and the behaviour of Chrysalis auto-updates), we should not consider firmware pre-releases as candidates, unless Chrysalis is also a snapshot version.

To this end, if the Chrysalis version does not have a -snapshot tag, filter out firmware pre-releases when trying to find the latest version.

Fixes #1163.

obra commented 2 years ago

This is absolutely the right fix for now, but we might want to consider making this a toggle in the prefs.