search

keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
496 stars 64 forks source link

CI: Add a workflow to build & publish unsigned pull request artifacts #1168

Closed algernon closed 2 years ago

algernon commented 2 years ago

Lately, we have been seeing - and creating - pull requests where user testing and feedback would be of incredible value. However, building from source is a barrier we don't want to put in front of potential testers.

For this reason, lets build and publish artifacts for pull requests aswell. They will not be signed - because we have no control over what gets built, really -, and they will not be uploaded to GitHub. They are made available nevertheless, and the workflow is set up so that it posts the URLs after the build to the originating pull request.

algernon commented 2 years ago

There's one more thing I want to do before this is merge ready: I want to make the portable exe available too. We just need to rename it in the pre-upload preparation step, and it's all good. Will do that later today.

chrysalis-pr-bot commented 2 years ago

Build artifacts for this pull request are available!

:warning: These are not official builds!

The build artifacts are provided as-is, for testing and reviewing purposes. They contain code that has not been reviewed or audited by Chrysalis' developers. They are not endorsed by Keyboardio, they are not signed. Install and use them only if you know what you are doing.

algernon commented 2 years ago

There we go, everything should be all fine now.

algernon commented 2 years ago

Hm... the version inside is a little bit awkward: Chrysalis 0.11.9-pr-1168.9-pr-1168.9, possibly due to tools/preinstall.js not being idempotent anymore. I'll fix that up.