keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
496 stars 64 forks source link

Secondary action layer shift dropdown menu is missing some layers #1179

Closed afcondon closed 2 years ago

afcondon commented 2 years ago

Describe the bug There's something strange about the selection dropdown for secondary action layer shift, some of my layers, the top two are missing from it. They can be seen in the regular layer shift dropdown

Screenshots

Here's a couple of screenshots that i think will demonstrate the problem

Secondary action

Secondary action

chrysalis-debug.json.txt

Desktop (please complete the following information):

algernon commented 2 years ago

Part of this is a bug, part of it is by design. Due to technical constraints, secondary action layer keys only support 8 layers, so Chrysalis does not display layers higher than those. However, we should be displaying 8 of them, not 7.

Perhaps it would make things clearer if we displayed the others too, but disabled selecting them, maybe with a tooltip that would explain why. I'll see what I can do about that.

algernon commented 2 years ago

Had a quick try: I can't add a useful tooltip, but what I can do, is display a note about the limitation along with the help text of the section if there are more than 8 layers available to select from, and then display the additional layers in the dropdown in a disabled state.

Will give that a try tomorrow.

afcondon commented 2 years ago

Thanks a lot for following up and the information. I think a simple note explaining the limitation ought to be fine. In my case i was only trying to make a secondary shift as a workaround for something related to the "disabled paste layer" issue.