keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
496 stars 64 forks source link

Chrysalis Release version is installing snapshot version of firmware #1195

Closed Random-Man81 closed 2 years ago

Random-Man81 commented 2 years ago

Describe the bug In the change log for 0.11.9 it says "Firmware updates are now restricted to the same channel as Chrysalis: a non-snapshot Chrysalis release will not consider snapshot firmware releases as eligible. If the application itself is at a snapshot version, however, it will."

I am running the release version of 0.11.9, but it installs the snapshot version of the firmware.

I had upgrade Chrysalis this morning from a version installed maybe 2 weeks ago. I was setting up my new model 100 so I did update to 0.91.0-snapshot.64. Then I realized that was snapshot. I thought that maybe I had a snapshot version of Chrysalis originally and so the update kept me on snapshot. So I downloaded 0.11.9 again directly from release tag on github and installed it again. After that it still was prompting me to use snapshot release of firmware.

To Reproduce Steps to reproduce the behavior:

  1. Go to Firmware Update
  2. See that it is offering the snapshot version.

Expected behavior I expect it to prompt me for 0.90.6+62 which seems to be the latest release.

Screenshots image

image

Desktop (please complete the following information):

Additional context Add any other context about the problem here. chrysalis-debug.json.txt

algernon commented 2 years ago

Bummer, I guess I typo'd something. Thanks for the report!

algernon commented 2 years ago

Ok, turns out that I didn't typo anything. It just happens that if snapshot firmware was previously downloaded, Chrysalis would still offer that for flashing, but it wouldn't download new snapshots. I'll add a check to the firmware update page so that it can properly discard a snapshot version if it needs to.