keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
496 stars 64 forks source link

Color map gets corrupted when restoring from backup #1198

Closed maralorn closed 2 years ago

maralorn commented 2 years ago

I am reiterating my comment from #1067 maybe it slipped through the cracks because I commented on a closed issue: This affected me again today, because updating to 0.91 again completely screwed all state on my keyboard, so I needed to load the map from backup:

Hey, I think I am encountering exactly this bug.

OS: Linux (NixOSR Chrysalis Version: 0.11.5 & 0.11.8 Kaleidoscope Version: 0.90.6

At, first updating the firmware from 0.90.3 to 0.90.6 completely garbled my keys and colors. (Did that with 0.11.8.) Then I successfully restored the keys from a backuped json, but everytime I load the backup the colors get mixed up like described here.

Let me demonstrate:

  1. Go to Layout -> Restore & Backup -> Load from File
  2. See this: image
  3. Click import, confirm.
  4. See this: image

If it is not clear, the colors displayed in the first image are the way I configured them.

I am suspecting this to be a chrysalis bug because the colors get garbled between loading and importing and before writing to the keyboard.

maralorn commented 2 years ago

My best guess is btw. that 0.90 had an (accidentally garbled key mapping somehow?), which got fixed with 0.91 so my 0.89 Layout wasn‘t compatible with 0.90 and now my 0.90 backup is now incompatible with 0.91

algernon commented 2 years ago

It's not that, it's the colormap restore code being bugged (#1059). I'll be closing this as a duplicate of #1059.