search

keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
496 stars 64 forks source link

LayoutSharing: Do not offer backups for import for now #1202

Closed algernon closed 2 years ago

algernon commented 2 years ago

Due to an earlier change, importing from backups made during flash are not importable via the "Backup & Restore" mechanism. Since the import was half-broken in this case anyway, lets disable this feature for now, until we develop a proper fix.

Addresses #1201 - but doesn't fix it.

obra commented 2 years ago

Will this hide the actual backup files, too?

algernon commented 2 years ago

Will this hide the actual backup files, too?

It removes the backup file list from the dialog only. If someone locates them, and tries to import them, that's not covered by this PR. That just counts as trying to import random JSON, and Chrysalis will throw an error on the dev console, but otherwise "silently" fail to import it.

We can - and will - add some form of verification before we import random stuff, but that's gonna take more effort. Locating the backup files isn't trivial, in my opinion, so for now, not showing the list should be enough. At least that gets the most obvious problem out of the way.

chrysalis-pr-bot commented 2 years ago

Build artifacts for this pull request are available!

:warning: These are not official builds!

The build artifacts are provided as-is, for testing and reviewing purposes. They contain code that has not been reviewed or audited by Chrysalis' developers. They are not endorsed by Keyboardio, they are not signed. Install and use them only if you know what you are doing.