keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
496 stars 64 forks source link

Setting modifiers for media control keys in Chrysalis causes a code to appear on the key. #1242

Open NabiYang opened 1 year ago

NabiYang commented 1 year ago

Below is the original bug. gdxpr clarified the issue in Discord stating that modifier keys can't be added to media control keys, however this isn't clear to the user.

https://discord.com/channels/492408953041321984/848761121182580766/1055172467330650162

The bug therefore is that it shows some code like #20661 instead of remaining Next Track with modifier toggles disabled (i.e., I shouldn't have been able to use the modifier toggle in the first place which changed the key label to a code).

Describe the bug When attempting to set a modifier for a media control key in Chrysalis, such as Shift+Next Track, it shows up as a code without the modifier toggle set. The code looks like #20661. I tested this in response to a Discord question about it.

https://discord.com/channels/492408953041321984/848761121182580766/1055058558682673162

I don't use this feature myself and don't know if the function is actually set to the key, but I suspect it isn't since the Shift modifier toggle in Chrysalis remains off.

To Reproduce Steps to reproduce the behavior:

  1. Set a key as Media control Next Track in Chrysalis.
  2. Click to turn on the Modifiers toggle Shift for that same key.
  3. ---> The modifier doesn't stay on and the key label turns to some code like #20661.

Expected behavior I expect the key label to show S+Next Track and to send that key combination when pressed.

Screenshots Can't Set Modifiers for Media Controls

chrysalis-debug.json.txt

Desktop (please complete the following information):

obra commented 1 year ago

Because the media keys aren't actually keyboard keys, doing modifiers on them is...complicated and likely not possible with the current design. Modifiers should be disabled in the UI for media keys.

-jesse

On Wed, Dec 21, 2022 at 8:06 AM NabiYang @.***> wrote:

Describe the bug When attempting to set a modifier for a media control key in Chrysalis, such as Shift+Next Track, it shows up as a code without the modifier toggle set. The code looks like #20661. I tested this in response to a Discord question about it.

https://discord.com/channels/492408953041321984/848761121182580766/1055058558682673162

I don't use this feature myself and don't know if they function is actually set to the key, but I suspect it isn't since the Shift modifier toggle in Chrysalis remains off.

To Reproduce Steps to reproduce the behavior:

  1. Set a key as Media control Next Track in Chrysalis.
  2. Click to turn on the Modifiers toggle Shift for that same key.
  3. ---> The modifier doesn't stay on and the key label turns to some code like #20661.

Expected behavior I expect the key label to show S+Next Track and to send that key combination when pressed.

Screenshots [image: Can't Set Modifiers for Media Controls] https://user-images.githubusercontent.com/58035835/208949161-a68484de-2736-4bce-8374-8a91b4950bff.jpg

chrysalis-debug.json.txt https://github.com/keyboardio/Chrysalis/files/10279305/chrysalis-debug.json.txt

Desktop (please complete the following information):

  • OS: Windows 11 Pro version 22H2
  • Chrysalis Version: 0.12.0

— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/issues/1242, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2HFHFQYFJD72W3CNLDWOMTJZANCNFSM6AAAAAATFZDUJA . You are receiving this because you are subscribed to this thread.Message ID: @.***>