search

keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
497 stars 65 forks source link

Use getFilesystemPathForStaticAsset() consistently, everywhere #1267

Closed algernon closed 1 year ago

algernon commented 1 year ago

Rather than using a hodge-podge mix of getStaticPath() and getFilesystemPathForStaticAsset() for the same purposes, just use the latter, everywhere. This allows us to make getStaticPath() private.

Furthermore, adjust both to actually return the correct path both in development, and in production mode. This fixes #1266.

github-actions[bot] commented 1 year ago

Build artifacts for this pull request are available!

:warning: These are not official builds!

The build artifacts are provided as-is, for testing and reviewing purposes. They contain code that has not been reviewed or audited by Chrysalis' developers. They are not endorsed by Keyboardio, they are not signed. Install and use them only if you know what you are doing.

You can download the platform-specific build artifacts from GitHub for 90 days after the date of this message from the following URL: https://github.com/keyboardio/Chrysalis/actions/runs/4920516248#artifacts

obra commented 1 year ago

approved.