search

keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
497 stars 65 forks source link

Chrysalis -- Shift 'secondary action' modifier doesn't work #1290

Open trocroi opened 1 year ago

trocroi commented 1 year ago

[edit 2023-07-05]

Describe the bug Keys that have "Secondary Action > Modifier > Shift" don't work as "Shift" if Space Cadet is enabled.

Expected behavior Regardless of Space Cadet setting, keys that have "Secondary Action > Modifier > Shift" should always send "Shift" regardless of Space Cadet setting.

In other words, "hold for modifier" should be unaffected by Space Cadet seting, because the "hold for modifier" base key is already supposed to send something that is probably not a parenthesis.

[original -- included for posterity]

Describe the bug neither 'shift' nor 'right shift' work when selected as 'secondary action > modifer when held'. I tried changing the base key to other keys, but that didn't help.

However, the other modifier keys do work in this selection -- i tested with CTRL, ALT, and WIN keys and they all are sent properly when held.

To Reproduce Steps to reproduce the behavior:

  1. set key as ENTER
  2. select 'secondary action' > 'when held' set to 'modifier'
  3. select 'shift' or 'right shift'
  4. flash firmware to board
  5. test typing in text editor of your choice, see that holding the key and typing a character doesn't produce the shifted output.

Expected behavior quoting from the Chrysalis blurb about the Secondary Action: [emphasis mine]

Lets you assign secondary functionality to a key. When tapping these augmented keys, you'll get the primary function. When holding them, the secondary action will be performed. Due to firmware limitations, shifting to layers above "#8" is not supported via secondary actions.

Screenshots image

Desktop (please complete the following information):

trocroi commented 1 year ago

update -- i have tried setting shift-as-modifier with many 'base' keys and i have not gotten it to work. have tried most of the alpha keys

trocroi commented 1 year ago

second edit! it works... if SpaceCadet is disabled.

I'm updating the "expected behavior" to match.

trocroi commented 1 year ago

personally i'd like to see this resolved but I'll close the ticket -- workaround is to manually define any desired shift keys as '(' or ')' and then set a Secondary Action modifier for Shift, and stop using Space Cadet.

trocroi commented 1 year ago

just kidding -- Chrysalis won't allow me to define a key to send a paren and hold for Shift.

simisimis commented 5 months ago

I explicitly disabled space cadet on default layout shift keys and uploaded keyboard layout. Shift keys then were set to off then again I reassigned those keys back to shift without enabling space cadet. And now shift started working as a secondary action on my home row keys.

simisimis commented 5 months ago

this workaround after all is very limited. Since I turned on my pc this morning and shift as a second modifier stopped working again :/

obra commented 5 months ago

can you confirm what version of Kaleidoscope you are running? If you go onto the firmware update screen in Chrysalis, it should show you.

On Mon, Apr 1, 2024 at 1:21 AM Simonas @.***> wrote:

this workaround after all is very limited. Since I turned on my pc this morning and shift as a second modifier stopped working again :/

— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/issues/1290#issuecomment-2029233766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2DIAHG3ZA6KD2P3GRDY3D4FFAVCNFSM6AAAAAAZ7IE3QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGIZTGNZWGY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

alanmoo commented 5 months ago

I'm also seeing this issue on a Model 100 (Firmware 0.92.6+116), Chrysalis 0.13.3

("this" being the edited issue: Keys that have "Secondary Action > Modifier > Shift" don't work as "Shift" if Space Cadet is enabled.)

obra commented 5 months ago

if you had one of the bad revisions of firmware in the middle, you may need to factory reset your keyboard. You should back up your layouts before you do that and load them in after. If that doesn’t solve it, please attach a copy of a backup to this issue.

On Mon, Apr 1, 2024 at 11:15 AM Alan Mooiman @.***> wrote:

I'm also seeing this issue on a Model 100 (Firmware 0.92.6+116), Chrysalis 0.13.3

— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/issues/1290#issuecomment-2030078438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2F2ZHY7CYUNMDOVW2LY3GBZVAVCNFSM6AAAAAAZ7IE3QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGA3TQNBTHA . You are receiving this because you commented.Message ID: @.***>

simisimis commented 5 months ago

can you confirm what version of Kaleidoscope you are running? If you go onto the firmware update screen in Chrysalis, it should show you.

I am running with 0.92.6+116 and indeed I tried today to backup my layout, reupload latest available firmware with a factory reset. After firmware flashed and I restored my layout, Shift modifier as secondary key started working again!