keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
493 stars 65 forks source link

Layout Editor doesn't indicate in the key label when Shift modifier is added for letters. #1302

Closed NabiYang closed 5 months ago

NabiYang commented 11 months ago

Describe the bug Using the Shift toggle to add shift to a key that types a letter doesn't show any indication in the key label. For example, if the letter A is assigned to a key, adding Control causes the label to read, "C+A". If I add the shift modifier to punctuation such as [, then it will show the shifted version {. But all the letters are shown in caps already in the layout editor, even though they aren't shifted. So it's impossible to tell from the label whether shift is included with that key without something like "S+A".

To Reproduce Steps to reproduce the behavior:

  1. Open Chrysalis and connect to keyboard.
  2. Select a key that has a letter assigned to it.
  3. Toggle on Shift under Modifiers.
  4. The label remains the same.

Expected behavior I expect the label to change indicating that shift is added to the letter.

Screenshots

Unmodified A Shifted A - This is the bug Control A - For comparison

-1692650178604.log

If applicable, add screenshots to help explain your problem. If possible, please also include the debug bundle you can create on the "Report a problem" screen. If, for some reason, you are unable to access that screen, please press Control + Shift + I (Windows or Linux) or Command + Option + I (macOS) to bring up the developer console. Right-clicking inside it will allow you to save its contents to a file - please attach that to the bug report.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

obra commented 5 months ago

I believe this to be fixed on https://chrysalis.keyboard.io. Please let me know if it isn't