keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
493 stars 65 forks source link

Firmware update screen claims to update to 0.92, but actually installs 0.91 #1306

Closed cflee closed 5 months ago

cflee commented 11 months ago

Describe the bug Firmware update claims that updating will go to 0.92 when it ends up installing 0.91.1+74.

Clicking on "What's New in 0.92.0?" results in 0.91.1 changelog.

To Reproduce Steps to reproduce the behavior:

  1. Connect to a Model 100
  2. Click on menu, Firmware Update

Expected behavior Firmware update version being displayed and offered should be 0.91.1+74 instead of 0.92.

Screenshots image image

chrysalis-debug.json.txt

Desktop (please complete the following information):

Additional context I discovered this while updating my keyboard that was previously on 0.90.x firmware (some snapshot version), after doing an update to Chrysalis 0.13.2 by downloading the setup exe (was previously on 0.11.x). The screenshots above are taken after running the update from Chrysalis 0.13.2 that claimed to bring it to 0.92.

obra commented 11 months ago

We pulled the 0.92 update after a report of adverse behavior from a Model 100 user. I suspect there's a caching issue causing it to report the removed 0.92 version.

On Sun, Sep 3, 2023 at 3:12 AM Chiang Fong Lee @.***> wrote:

Describe the bug Firmware update claims that updating will go to 0.92 when it ends up installing 0.91.1+74.

Clicking on "What's New in 0.92.0?" results in 0.91.1 changelog.

To Reproduce Steps to reproduce the behavior:

  1. Connect to a Model 100
  2. Click on menu, Firmware Update

Expected behavior Firmware update version being displayed and offered should be 0.91.1+74 instead of 0.92.

Screenshots [image: image] https://user-images.githubusercontent.com/8225175/265257784-456e5059-b530-4c65-9df9-9cdf038ad590.png [image: image] https://user-images.githubusercontent.com/8225175/265257819-7bf2c2de-8b97-4ff2-a1de-82060acac154.png

chrysalis-debug.json.txt https://github.com/keyboardio/Chrysalis/files/12505684/chrysalis-debug.json.txt

Desktop (please complete the following information):

  • OS: Windows 10
  • Chrysalis Version: 0.13.2

Additional context I discovered this while updating my keyboard that was previously on 0.90.x firmware (some snapshot version), after doing an update to Chrysalis 0.13.2 by downloading the setup exe (was previously on 0.11.x). The screenshots above are taken after running the update from Chrysalis 0.13.2 that claimed to bring it to 0.92.

— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/issues/1306, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2BS34FFW7FXKAWMP63XYRJXZANCNFSM6AAAAAA4JGXVUU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

shofutex commented 7 months ago

I receive the same behavior trying to update to 0.92.1. The attached is what Chrysalis shows after installing 0.92.1. Screenshot from 2023-12-19 22-33-25

obra commented 7 months ago

If you're up for trying what will be released as Chrysalis 0.13.3 tomorrow, it should fix this issue: https://github.com/keyboardio/Chrysalis/releases/tag/v0.13.3

On Tue, Dec 19, 2023 at 7:32 PM shofutex @.***> wrote:

I receive the same behavior trying to update to 0.92.1.

— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/issues/1306#issuecomment-1863794772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2C7USPSIS5KX3EGX4TYKJL33AVCNFSM6AAAAAA4JGXVUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTG44TINZXGI . You are receiving this because you commented.Message ID: @.***>

shofutex commented 7 months ago

Yes, that fixed the issue for me. Thanks!