keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
493 stars 65 forks source link

db.js dual-use modifiers section doesn't match dualuse.js after right hand modifiers were added. #1316

Closed NabiYang closed 5 months ago

NabiYang commented 7 months ago

Describe the bug Right hand modifiers with indices 4, 5, and 7 were added to dualuse.js but they're absent from db.js in the setLayout(). The dual use right hand modifiers work correctly when assigned in Chrysalis, so I'm unsure what difference this makes. But it's worth looking at.

To Reproduce

  1. Check the "// dual-use modifiers" section in setLayout(). https://github.com/keyboardio/Chrysalis/blob/master/src/api/focus/keymap/db.js
  2. ---> "for (const m of [0, 1, 2, 3, 6]) {" is missing indices 4, 5, and 7 which can be found in dualuse.js. https://github.com/keyboardio/Chrysalis/commit/4d4d71c56b52f5d750a406af889e21bf7713fee5

Expected behavior I expected the indices to match between the two files.

Screenshots image image

obra commented 5 months ago

Fixed