search

keyboardio / Chrysalis

Graphical configurator for Kaleidoscope-powered keyboards
https://github.com/keyboardio/Chrysalis#chrysalis
GNU General Public License v3.0
493 stars 65 forks source link

On firmware updates, only the *first* layer name is currently restored #1328

Closed obra closed 5 months ago

obra commented 5 months ago

When doing the backup:

image

It's then sent back to the keyboard fine:

image

Then it looks like we drop it when sending it back to chrysalis:

image

I don't yet know whether this is a bug in Chrysalis or Kaleidoscope

obra commented 5 months ago

It looks like we're sending back to the keyboard in a different format than the keyboard is sending to us. The layernames wire format is a little bit...complicated in ways it probably shouldn't be. So it may take some care to untangle

obra commented 5 months ago

I didn't grab a screenshot, but it looked like when trying to do the restore of layernames, Chrysalis sent a bunch of newlines, which kaleidoscope wasn't expecting and interpreted each one as a separate command.

obra commented 5 months ago

Fixed in c07689648b9daaa0a83dbc2080ed7b38bcf105b4