Open algernon opened 2 years ago
Rom1deTroyes
commented
2 years ago Sorry if my proposition is out of scope (I don't know if the floating keyboard is designed to be always present on the editor screen), but maybe a close control button on the floating keyboard can be useful for one trapped in a situation where only the float keyboard is visible ?
The UI job is great, and wish I had time to help testing it !
obra
commented
2 years ago (It's currently designed to always be visible.)
On Fri, May 20, 2022 at 11:55 PM Romain Heller @.***> wrote:
Sorry if my proposition is out of scope (I don't know if the floating keyboard is designed to be always present on the editor screen), but maybe a close control button on the floating keyboard can be useful for one trapped in a situation where only the float keyboard is visible ?
The UI job is great, and wish I had time to help testing it !
— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/issues/810#issuecomment-1133550398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2D54X4PCNU2WLSMYITVLCCHRANCNFSM5WQL232Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Rom1deTroyes
commented
2 years ago I hijack once again this issue, this time as a reminder from discord discussion :
When the app window is resized, panes are resized, the Atreus keyboard is resized, but the picker stays where it was (if you cut the width by half, the numpad disappears).
Not a big deal when you realize that you can move it by click and dragging, but surprising enough ?
The UI enhancements are really great !
algernon
commented
2 years ago I looked for possible fixes, and my current opinion is that instead of scaling the floating keypicker, we should make sure the main keyboard doesn't scale past a bottom margin, and when the window is scaled, the floating keypicker should scale similarly aswell (just like the main SVG does).
Describe the bug
The floating keyboard on the Editor screen is very, very nice, and works great when the window is sufficiently large, and we're connected to a smaller keyboard like the Atreus.
If the screen is smaller, or the keyboard is bigger, multiple problems can occur, which I'll present with screenshots:
Model01 @ full screen
Even at a very reasonable window size, the Model01's palm keys are partially covered. It doesn't render anything unusable, but it doesn't look good.
Model01 @ smaller window
It gets worse when we decrease the window size:
The floating keyboard is partially off-screen, and covers the sidebar too.
Atreus @ smaller window
The problem persists with the Atreus too, at smaller window sizes
Suggestions
We should probably set a minimum window size, prevent the floating keyboard from moving off-screen (if possible, I'd prevent it from moving into the sidebar too), and we should likely scale it down too if the window gets too small.