search

keyboardio / Kaleidoscope-Bundle-Keyboardio

A Kaleidoscope distribution for the Keyboardio Model 01 and other keyboards.
Other
17 stars 24 forks source link

Fixed build errors with follow up builds after a failed attempt to link #19

Closed noseglasses closed 5 years ago

noseglasses commented 5 years ago

In rare occasions during development when e.g. a missing symbol caused the linker process to abort, the joined library was not removed at the end of the build. In subsequent builds this possibly caused problems during creation of the joined library as a static library cannot be updated but must be removed and re-created.

This change solves the described problem by removing a possibly pre-exising joined library before the link.

This is tested to work on Windows and Linux. Only the Windows part actually changed, so macOS should be fine, too.

Signed-off-by: Florian Fleissner florian.fleissner@inpartik.de

noseglasses commented 5 years ago

Travis testing seems to be broken again. This seems unrelated to this PR, at least I cannot reproduce it. On my Linux-box smoke-examples run fine.