search

keyboardio / Kaleidoscope-Bundle-Keyboardio

A Kaleidoscope distribution for the Keyboardio Model 01 and other keyboards.
Other
17 stars 24 forks source link

Prepare to refactor KALEIDOSCOPE_HARDWARE_H since cmake can't digest it. #37

Closed paniag closed 4 years ago

paniag commented 4 years ago

cmake sees

#include KALEIDOSCOPE_HARDWARE_H

and complains that KALEIDOSCOPE_HARDWARE_H is not of the form "filename" or <filename>.

This change defines new symbols, one per platform, like KALEIDOSCOPE_HARDWARE_MODEL01. The idea is that in the two places in Kaleidoscope where KALEIDOSCOPE_HARDWARE_H is used we can instead import a real file that contains a conditional compilation with #includes having the acceptable form (ie including a real file).

obra commented 4 years ago

We've been discussing this on discord and it sounds like we may end up needing to try another solution, since we don't want to hardcode a board list in the kaleidoscope source.

paniag commented 4 years ago

This has been solved through a different mechanism in the context of cmake. See https://github.com/keyboardio/Kaleidoscope/commit/978097bb42bad35e96725aac5076169e95ddc3db