search

keyboardio / Kaleidoscope-Bundle-Keyboardio

A Kaleidoscope distribution for the Keyboardio Model 01 and other keyboards.
Other
17 stars 24 forks source link

Merge epan/build/justlib into master #40

Closed paniag closed 3 years ago

paniag commented 3 years ago

This only affects the virtual build. That said, it will completely break things if keyboardio/Kaleidoscope:epan/testing/main isn't merged at the same time. The point is that the latter depends on the configuration provided by the former, and the configuration provided by the former will break virtual builds on any other branch of keyboardio:Kaleidoscope until epan/testing/main is merged. This PR draft is here for discussion and potentially future action.

obra commented 3 years ago

+1 to merge as soon as we're good to merge the other bits. (Though since virtual builds aren't used yet on main, I'm ok with merging it right away with @algernon's +1)

algernon commented 3 years ago

Since we aren't using virtual builds on master yet, this is safe to merge.

:+1:

obra commented 3 years ago

Thanks. Merged.