keyboardio / KeyboardioHID

A HID library for Arduino
MIT License
34 stars 17 forks source link

Support for horizontal mouse wheel movement. #12

Closed SjB closed 6 years ago

SjB commented 6 years ago

Extended the HID Descriptor to send a Consumer Device page that support a horizontal mouse scroll wheel

obra commented 6 years ago

Hi Steve,

Thanks so much for the PRs!

I'd love to know more about the use case (I don't think I've seen a mouse with dual scroll wheels).

As concrete first comments on this and the associated pull requests:

On Mon, Nov 6, 2017 at 9:19 PM, Steve Beaulac notifications@github.com wrote:

Extended the HID Descriptor to send a Consumer Device page that support a vertical mouse scroll wheel

You can view, comment on, or merge this pull request online at:

https://github.com/keyboardio/KeyboardioHID/pull/12 Commit Summary

  • Support for Vertical mouse wheel movement.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/keyboardio/KeyboardioHID/pull/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AACxaGOpSTaWykY6u5cHZfiLG1yD2ijsks5sz-hPgaJpZM4QURqS .

SjB commented 6 years ago

@obra

To start with the feature should be Support for horizontal mouse wheel, major typo on my part. I use the mouse wheel to scroll up, down, left, right when I'm look at documents. On many coding website when code sample are shown in text box the text box has a horizontal scroll bar and it's just easier for me to use the keyboard to scroll the content with the keyboard keys.

algernon commented 6 years ago

The build failure is due to an out-of-date Arduino-Boards. If retried, it should pass now.

obra commented 6 years ago

The build failure is due to getting the wrong 'HID' library. But merging :)

obra commented 6 years ago

Thanks! Applied.