search

keyboardio / KeyboardioHID

A HID library for Arduino
MIT License
34 stars 17 forks source link

Mouse: Rework the USB descriptors #19

Closed algernon closed 6 years ago

algernon commented 6 years ago

Instead of bundling X, Y, and Wheel together, pull out the latter, split it into resolution modifier + wheel, and base the horizontal wheel on top of that. Functionally, this should be the same, just structured in a different way.

This seems to upset at least Linux a lot less, and will hopefully fix #18.

algernon commented 6 years ago

@TheBaronHimself, @jamesnvc: Could any of you test this on OSX? (and perhaps Windows too, if either of you has access to one)

Thanks in advance!

TheBaronHimself commented 6 years ago

Did a quick test on macOS High Sierra and Windows 10 and it appears to work as intended :).

gedankenexperimenter commented 6 years ago

Does GitHub really not provide any link to the repository that a PR came from? It's really surprising that I have to manually search for @algernon's repository from here in order to add it as a remote, check out this branch and test it out.

jamesnvc commented 6 years ago

@gedankenexperimenter you can fetch the pull request from the repo by doing git fetch origin pull/ID/head:BRANCHNAME (see https://help.github.com/articles/checking-out-pull-requests-locally/#modifying-an-inactive-pull-request-locally).

gedankenexperimenter commented 6 years ago

I can also confirm that this fixes the problem I reported last night (Arduino-Boards #12)

gedankenexperimenter commented 6 years ago

@jamesnvc – Thanks! That does help a bit, but it's still pretty surprising that at the top of this page, the text algernon:h/mouse/descriptor-rework is not a link to the h/mouse/descriptor-rework in the repo algernon/KeyboardioHID.