Closed algernon closed 6 years ago
The downside of this revert & fix is that we lose the nicely formatted comments. Mind you, the indentation of that wasn't particularly great...
If needed, I'll add similar contents to this PR, once verified that it works on OSX & Windows too.
Fixups applied here: https://github.com/keyboardio/KeyboardioHID/compare/master...keyboardio:algernon-f/mouse/even-better-usb-descriptors?expand=1
It uncovered what looks like a bug in report count
Updated my branch with yours, thanks!
As explained above, the report count is correct now, it did change from 2 back to 3 now. The previous comment was wrong.
As it turns out, the real problem was two typos,
D_USAGE_MINIMUM
andD_USAGE_MAXIMUM
were used in the horizontal wheel descriptor instead ofD_LOGICAL_MINIMUM
andD_LOGICAL_MAXIMUM
.This patch reverts the previous USB HID descriptor rework, and fixes the horizontal wheel descriptor only, saving us some 46 bytes of program space.
Tested & works on Linux, but to make sure we don't re-break OSX, testing there would be most appreciated.